From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 04 Mar 2008 15:01:28 GMT
Subject: Re: [PATCH] git-submodule: Don't die when command fails for one submodule
Message-ID: <alpine.LSU.1.00.0803041500170.22527@racer.site>
In-Reply-To: <1204641314-2726-1-git-send-email-pkufranky@gmail.com>

Hi,

On Tue, 4 Mar 2008, Ping Yin wrote:

> When handling multiple modules, init/update/status command will exit 
> when it fails for one submodule. This patch makes the command continue 
> bypassing the failure.

I think that you should not do this.  The failure should not be ignored.  
Maybe continuing, but not forgetting about the error.  So:

> -		name=$(module_name "$path") || exit
> +		name=$(module_name "$path") || continue

I do not like this.  It should remember that there was something foul, and 
eventually exit with that status.

Ciao,
Dscho