Re: [PATCH] http-push: add regression tests

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 27, 2008, 09:51 UTC
Message-ID: <alpine.LSU.1.00.0802270947110.22527@racer.site>
In-Reply-To: <20080227085442.GA22501@localhost>

Hi,

On Wed, 27 Feb 2008, Clemens Buchacher wrote:

> Networking tests are disabled by default. Use GIT_TEST_OPTS=--network to
> enable.

One request in addition to Mike's: please make this an environment variable such as "GIT_TEST_HTTPD". IOW, instead of this:

Show 28 quoted lines

> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 83889c4..e33b13b 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -79,8 +79,10 @@ do
>  		verbose=t; shift ;;
>  	-q|--q|--qu|--qui|--quie|--quiet)
>  		quiet=t; shift ;;
> +	-n|--n|--ne|--net|--netw|--netwo|--networ|--network)
> +		network=t; shift ;;
>  	--no-color)
> -	    color=; shift ;;
> +		color=; shift ;;
>  	--no-python)
>  		# noop now...
>  		shift ;;
> @@ -89,6 +91,11 @@ do
>  	esac
>  done
>  
> +if test -n "$network"
> +then
> +	GIT_TEST_NET=t
> +fi
> +
>  if test -n "$color"; then
>  	say_color () {
>  		case "$1" in

just rename the variable "GIT_TEST_NET" in lib-httpd.sh to "GIT_TEST_HTTPD".

Thanks, Dscho