Re: [PATCH] http-push: add regression tests

From: Mike Hommey <mh@glandium.org>
Date: Feb 24, 2008, 18:48 UTC
Message-ID: <20080224184832.GA24240@glandium.org>
In-Reply-To: <20080224180340.GA11515@localhost>

On Sun, Feb 24, 2008 at 07:03:40PM +0100, Clemens Buchacher wrote:

Show 10 quoted lines

> http-push tests require a web server with WebDAV support.
> 
> This commit introduces a HTTPD test library, which can be configured using
> the following environment variables.
> 
> LIB_HTTPD_PATH	web server path
> LIB_HTTPD_PORT	listening port
> LIB_HTTPD_DAV	enable DAV
> LIB_HTTPD_SVN	enable SVN
> LIB_HTTPD_SSL	enable SSL

I'd add LIB_HTTPD_MODULE_PATH in here ;)

I took a quick but deeper look to your script, and I think it would be better to have a httpd.conf with proper <IfDefine> directives, and toggle the proper defines on the httpd command line.

Note the ServerRoot is used when paths are relative, so only the ServerRoot need to be set, and it could be set with the -C argument to httpd, avoiding the need of a .in file. If necessary, modules path could be made relative to the ServerRoot by means of a symlink.

Avoiding to have logs, dav lock, ssl mutex, etc. in the document root would be better, too, but that is nitpicking.

Mike