git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] http-push: add regression tests

From
Clemens Buchacher <drizzd@aon.at>
Date
Feb 27, 2008, 19:23 UTC
Message-ID
<20080227192334.GA1818@localhost>
In-Reply-To
<alpine.LSU.1.00.0802270947110.22527@racer.site>
Hi,
On Wed, Feb 27, 2008 at 09:51:35AM +0000, Johannes Schindelin wrote:
> just rename the variable "GIT_TEST_NET" in lib-httpd.sh to 
> "GIT_TEST_HTTPD".

My intention was to use this variable as a global "enable network testing" flag, as implicated by Junio. I don't see a real usecase for enabling only HTTPD tests, as opposed to other networking tests for git-daemon or git-shell, for example. But here you go.

On Wed, Feb 27, 2008 at 10:16:42AM +0100, Mike Hommey wrote:
Show 7 quoted lines
> > I wanted to state explicitly that HTTPD_ROOT_PATH and
> > HTTPD_DOCUMENT_ROOT_PATH do not have to be related. I added the -p flag to
> > both commands, however.
> 
> They *are* related, because HTTPD_DOCUMENT_ROOT_PATH is what is in
> httpd.conf, set with the DocumentRoot directive, and it's a path relative to
> HTTPD_ROOT_PATH. And it is set statically to "www".

This dependency can easily be removed by using a symlink. But I don't feel strongly enough about this point to resist any longer. :-)

Thank you again for your numerous suggestions. I will resubmit both patches in reply to this message.

Regards, Clemens

Previous: Johannes SchindelinNext: Clemens Buchacher
Message 23 of 27 in “http-push: Fix error message for push <remote> :<branch>”
  1. http-push: Fix error message for push <remote> :<branch>Clemens Buchacher, Feb 18, 2008
  2. Johannes SchindelinFeb 18, 2008
  3. http-push: push <remote> :<branch> deletes remote branchClemens Buchacher, Feb 18, 2008
  4. http-push: push <remote> :<branch> deletes remote branchClemens Buchacher, Feb 18, 2008
  5. Johannes SchindelinFeb 18, 2008
  6. Johannes SchindelinFeb 18, 2008
  7. Clemens BuchacherFeb 19, 2008
  8. Johannes SchindelinFeb 19, 2008
  9. Mike HommeyFeb 19, 2008
  10. Johannes SchindelinFeb 19, 2008
  11. Junio C HamanoFeb 19, 2008
  12. Johannes SchindelinFeb 19, 2008
  13. http-push: add regression testsClemens Buchacher, Feb 23, 2008
  14. Mike HommeyFeb 24, 2008
  15. http-push: add regression testsClemens Buchacher, Feb 24, 2008
  16. Mike HommeyFeb 24, 2008
  17. Clemens BuchacherFeb 24, 2008
  18. http-push: add regression testsClemens Buchacher, Feb 25, 2008
  19. Junio C HamanoFeb 26, 2008
  20. http-push: add regression testsClemens Buchacher, Feb 27, 2008
  21. Mike HommeyFeb 27, 2008
  22. Johannes SchindelinFeb 27, 2008
  23. Clemens BuchacherFeb 27, 2008
  24. 1/2 http-push: push <remote> :<branch> deletes remote branchClemens Buchacher, Feb 27, 2008
  25. 2/2 http-push: add regression testsClemens Buchacher, Feb 27, 2008
  26. Johannes SchindelinFeb 27, 2008
  27. Mike HommeyFeb 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.