Re: [PATCH] http-push: add regression tests

From: Mike Hommey <mh@glandium.org>
Date: Feb 27, 2008, 09:16 UTC
Message-ID: <20080227091640.GA19272@glandium.org>
In-Reply-To: <20080227085442.GA22501@localhost>

On Wed, Feb 27, 2008 at 09:54:42AM +0100, Clemens Buchacher <drizzd@aon.at> wrote:

Show 16 quoted lines

> http-push tests require a web server with WebDAV support.
> 
> This commit introduces a HTTPD test library, which can be configured using
> the following environment variables.
> 
> LIB_HTTPD_PATH		web server path
> LIB_HTTPD_MODULE_PATH	web server modules path
> LIB_HTTPD_PORT		listening port
> LIB_HTTPD_DAV		enable DAV
> LIB_HTTPD_SVN		enable SVN
> LIB_HTTPD_SSL		enable SSL
> 
> Networking tests are disabled by default. Use GIT_TEST_OPTS=--network to
> enable.
> 
> Signed-off-by: Clemens Buchacher <drizzd@aon.at>

Acked-by: Mike Hommey <mh@glandium.org>

However, last remark:

> I wanted to state explicitly that HTTPD_ROOT_PATH and HTTPD_DOCUMENT_ROOT_PATH
> do not have to be related. I added the -p flag to both commands, however.

They *are* related, because HTTPD_DOCUMENT_ROOT_PATH is what is in httpd.conf, set with the DocumentRoot directive, and it's a path relative to HTTPD_ROOT_PATH. And it is set statically to "www".

Mike