From: Daniel Barkalow Date: Thu, 29 Oct 2009 18:43:41 GMT Subject: Re: [PATCH 7/7] Factor ref updating out of fetch_with_import Message-ID: In-Reply-To: On Thu, 29 Oct 2009, Sverre Rabbelier wrote: > Heya, > > On Thu, Oct 29, 2009 at 10:22, Daniel Barkalow wrote: > > (a) if HEAD is determined to be a symref, and we care about HEAD, we care > > about whatever HEAD is a symref to; wanted_peer_refs() shouldn't be > > filtering such things out. > > It seems that wanted_peer_refs filters out HEAD no matter what though? It probably shouldn't. Actually, I bet Nico's clone will get extremely confused if the remote's HEAD isn't the same as any of its branches. I'll try to take a look tonight. > > (b) we don't want to make a whole bunch of copies of the ref list to avoid > > updating the mutable ref list that we will look for updated values in; the > > merge of my series with Nico's should replace my copy_ref_list with his > > wanted_peer_refs, not include the copy afterwards. Correcting this should > > lead to the value that matters in the list that will be used having been > > updated directly by transport_fetch_refs(). > > This I can and will fix. Patch-bomb incoming. I'll look over it later, thanks. -Daniel *This .sig left intentionally blank*