Re: [PATCH RFC/RFD] clone: quell the progress report from init

From: Nicolas Pitre <nico@fluxnic.net>
Date: Mar 26, 2010, 20:16 UTC
Message-ID: <alpine.LFD.2.00.1003261611130.694@xanadu.home>
In-Reply-To: <7veij6lvze.fsf@alter.siamese.dyndns.org>

On Fri, 26 Mar 2010, Junio C Hamano wrote:

Show 16 quoted lines

> An alternative might be to squelch init_db() like your patch did, and then
> replace it with a message of our own, perhaps like this:
> 
>  $ git clone -n /var/tmp/gomi victim-003
>  Cloning into victim-003...
>  done.
>  $ git clone -n file:///var/tmp/gomi victim-004
>  Cloning into victim-004...
>  remote: Counting objects: ...
>  Receiving objects: 100% (120/120), done.
> 
> Here I am assuming we would add "done." to the local codepath.
> 
> Personally I like the total silence your patch gives (i.e. no "Cloning
> into" line in either case, and no "done." in local case) slightly better;
> others may disagree and/or have better ideas.

Personally I like your suggestion above. A clone is not something you perform repeatedly, and it is the first thing that random people told to use Git to grab a piece of code will do. Better give them some comfort by telling them what is happening.

Nicolas