Re: [PATCH RFC/RFD] clone: quell the progress report from init

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Mar 30, 2010, 08:05 UTC
Message-ID: <4BB1B0AF.7060206@drmicha.warpmail.net>
In-Reply-To: <7v7houxu8n.fsf@alter.siamese.dyndns.org>

Junio C Hamano venit, vidit, dixit 30.03.2010 07:18:

Show 10 quoted lines

> Nicolas Pitre <nico@fluxnic.net> writes:
> 
>> Personally I like your suggestion above.  A clone is not something you 
>> perform repeatedly, and it is the first thing that random people told to 
>> use Git to grab a piece of code will do.  Better give them some comfort 
>> by telling them what is happening.
> 
> Here is what such a change may look like.  I'll leave adjusting
> documentation (namely, tutorials) and perhaps tests as an exercise to the
> readers ;-)

OK, I'll take it since I kicked this off.

Show 25 quoted lines

>  builtin/clone.c  |    6 +++++-
>  t/t5601-clone.sh |    2 +-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/builtin/clone.c b/builtin/clone.c
> index 05f8fb4..0bedde4 100644
> --- a/builtin/clone.c
> +++ b/builtin/clone.c
> @@ -302,6 +302,8 @@ static const struct ref *clone_local(const char *src_repo,
>  	transport = transport_get(remote, src_repo);
>  	ret = transport_get_remote_refs(transport);
>  	transport_disconnect(transport);
> +	if (0 <= option_verbosity)
> +		printf("done.\n");
>  	return ret;
>  }
>  
> @@ -461,7 +463,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
>  		die("could not create leading directories of '%s'", git_dir);
>  	set_git_dir(make_absolute_path(git_dir));
>  
> -	init_db(option_template, (option_verbosity < 0) ? INIT_DB_QUIET : 0);
> +	if (0 <= option_verbosity)
> +		printf("Cloning into %s...\n", get_git_dir());
> +	init_db(option_template, INIT_DB_QUIET);

Don't we want init to report at least with -v?

Show 16 quoted lines

>  
>  	/*
>  	 * At this point, the config exists, so we do not need the
> diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
> index 2147567..678cee5 100755
> --- a/t/t5601-clone.sh
> +++ b/t/t5601-clone.sh
> @@ -34,7 +34,7 @@ test_expect_success 'clone with excess parameters (2)' '
>  test_expect_success 'output from clone' '
>  	rm -fr dst &&
>  	git clone -n "file://$(pwd)/src" dst >output &&
> -	test $(grep Initialized output | wc -l) = 1
> +	test $(grep Clon output | wc -l) = 1
>  '
>  
>  test_expect_success 'clone does not keep pack' '

Michael