[PATCH RFC/RFD] clone: quell the progress report from init
- From
Michael J Gruber <git@drmicha.warpmail.net>
- Date
- Mar 25, 2010, 08:46 UTC
- Message-ID
- <7b9006620fab4214ee0db53ebc9e0caffc397959.1269506526.git.git@drmicha.warpmail.net>
- In-Reply-To
- <4BAB2234.4070202@drmicha.warpmail.net>
Currently, cloning a local repository results in the progress report "Initialized empty Git repository in ..." from init but no other output, leaving the user to wonder what happened to the actual cloning.
Therefore, quell the progress report from init (unless -v is given) to be in line with the many other commands which report nothing on success.
Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net> --- This is RFC/RFD. An actual patch will also adjust several tests to the new expected output. Also, one might want to change init's default verbosity level accordingly.
The current output is really confusing for local cloning. There are several alternative ways to resolve this: - Make the local cloning process report something. - Check whether the clone is remote or not and report init or don't.
Currently, we really have two philosophies: - report only on error - be chatty on success
I don't think that's a problem, but "simple" commands (e.g. branch, init, add) should be in the former camp.
builtin/clone.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin/clone.c b/builtin/clone.c index 05f8fb4..f98c5c5 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -461,7 +461,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix) die("could not create leading directories of '%s'", git_dir); set_git_dir(make_absolute_path(git_dir)); - init_db(option_template, (option_verbosity < 0) ? INIT_DB_QUIET : 0); + init_db(option_template, (option_verbosity <= 0) ? INIT_DB_QUIET : 0); /* * At this point, the config exists, so we do not need the
-- 1.7.0.3.448.g82eeb