Re: [PATCH RFC/RFD] clone: quell the progress report from init

From: Alex Riesen <raa.lkml@gmail.com>
Date: Mar 25, 2010, 09:02 UTC
Message-ID: <81b0412b1003250202m67dc4d2m9042d1242800cd27@mail.gmail.com>
In-Reply-To: <7b9006620fab4214ee0db53ebc9e0caffc397959.1269506526.git.git@drmicha.warpmail.net>

On Thu, Mar 25, 2010 at 09:46, Michael J Gruber <git@drmicha.warpmail.net> wrote:

Show 6 quoted lines

> Currently, we really have two philosophies:
> - report only on error
> - be chatty on success
>
> I don't think that's a problem, but "simple" commands (e.g. branch, init,
> add) should be in the former camp.

Right. Everytime add scrolls out the current terminal buffer I wish I had it sent to /dev/null.

>  builtin/clone.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Sometimes I think a statistics like "1 byte inserted" are more appropriate :)

> -       init_db(option_template, (option_verbosity < 0) ? INIT_DB_QUIET : 0);
> +       init_db(option_template, (option_verbosity <= 0) ? INIT_DB_QUIET : 0);