git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Makefile: make ppc/sha1ppc.o depend on GIT-CFLAGS

From
Nicolas Pitre <nico@fluxnic.net>
Date
Jan 6, 2010, 18:17 UTC
Message-ID
<alpine.LFD.2.00.1001061309540.21025@xanadu.home>
In-Reply-To
<20100106063759.GA882@progeny.tock>
On Wed, 6 Jan 2010, Jonathan Nieder wrote:
Show 8 quoted lines
> The %.o: %.S pattern rule should depend on GIT-CFLAGS to avoid
> trouble when ALL_CFLAGS changes.
> 
> The pattern only applies to one file (ppc/sha1ppc.S) and that
> file does not use any #ifdefs, so leaving the dependency out is
> probably harmless.  Nevertheless, it is safer to include the
> dependency in case future code's behavior does depend on the
> build flags.
Is the PPC SHA1 code still needed?  Is it actually ever used?

We have block-sha1/* which is already about just as fast if not faster on most targets. So I'd simply remove the ppc directory and its content which is the only remaining platform specific assembly code in the source tree.

Nicolas
Previous: Jonathan NiederNext: Jonathan Nieder
Message 6 of 20 in “Makefile fixes”
  1. 0/4 Makefile fixesJonathan Nieder, Nov 28, 2009
  2. 1/4 Makefile: fix http-push.o dependenciesJonathan Nieder, Nov 28, 2009
  3. Junio C HamanoNov 28, 2009
  4. 2/4 Makefile: make ppc/sha1ppc.o depend on GIT-CFLAGSJonathan Nieder, Nov 28, 2009
  5. Makefile: make ppc/sha1ppc.o depend on GIT-CFLAGSJonathan Nieder, Jan 6, 2010
  6. Nicolas PitreJan 6, 2010
  7. 3/4 Makefile: fix .s pattern rule dependenciesJonathan Nieder, Nov 28, 2009
  8. 0/5 Makefile: fix generation of assembler listingsJonathan Nieder, Jan 6, 2010
  9. 1/5 Makefile: regenerate assembler listings when askedJonathan Nieder, Jan 6, 2010
  10. 2/5 Makefile: use target-specific variable to pass flags to ccJonathan Nieder, Jan 6, 2010
  11. Jonathan NiederJan 7, 2010
  12. 3/5 Makefile: learn to generate listings for targets requiring special flagsJonathan Nieder, Jan 6, 2010
  13. 4/5 Makefile: consolidate .FORCE-* targetsJonathan Nieder, Jan 6, 2010
  14. 5/5 git-gui/Makefile: consolidate .FORCE-* targetsJonathan Nieder, Jan 6, 2010
  15. Shawn O. PearceJan 7, 2010
  16. Linus TorvaldsJan 6, 2010
  17. 4/4 Makefile: do not clean arm directoryJonathan Nieder, Nov 28, 2009
  18. Nanako ShiraishiJan 1, 2010
  19. Junio C HamanoJan 6, 2010
  20. Jonathan NiederJan 6, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.