[PATCH 3/4] Makefile: fix .s pattern rule dependencies
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Nov 28, 2009, 11:37 UTC
- Message-ID
- <20091128113709.GD10059@progeny.tock>
- In-Reply-To
- <20091128112546.GA10059@progeny.tock>
'make git.s' fails to regenerate an assembler listing if git.c has not changed but a header it includes has. The %.s: %.c pattern rule is meant to be invoked by hand, so it would be better to make it always run.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> --- This adds yet another phony .FORCE-foo target. Wouldn’t it be simpler to use a single target called .FORCE, or is there something I am missing that that would break?
Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile index bb3879e..cd210e3 100644 --- a/Makefile +++ b/Makefile @@ -1524,7 +1524,7 @@ git.o git.spec \ %.o: %.c GIT-CFLAGS $(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) $< -%.s: %.c GIT-CFLAGS +%.s: %.c GIT-CFLAGS .FORCE-LISTING $(QUIET_CC)$(CC) -S $(ALL_CFLAGS) $< %.o: %.S GIT-CFLAGS $(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) $< @@ -1859,7 +1859,7 @@ endif .PHONY: all install clean strip .PHONY: shell_compatibility_test please_set_SHELL_PATH_to_a_more_modern_shell .PHONY: .FORCE-GIT-VERSION-FILE TAGS tags cscope .FORCE-GIT-CFLAGS -.PHONY: .FORCE-GIT-BUILD-OPTIONS +.PHONY: .FORCE-GIT-BUILD-OPTIONS .FORCE-LISTING ### Check documentation #
-- 1.6.5.3