Re: [PATCH] upload-pack: squelch progress indicator if client does not request sideband

From: Nicolas Pitre <nico@cam.org>
Date: Jun 16, 2009, 19:46 UTC
Message-ID: <alpine.LFD.2.00.0906161542590.16467@xanadu.home>
In-Reply-To: <200906162041.16608.j6t@kdbg.org>

On Tue, 16 Jun 2009, Johannes Sixt wrote:

Show 17 quoted lines

> On Dienstag, 16. Juni 2009, Nicolas Pitre wrote:
> > On Mon, 15 Jun 2009, Junio C Hamano wrote:
> > > Stated differently, I think "not using sideband _and_ spawned via daemon"
> > > would be an indication that "the client won't see the progress anyway
> > > even if it were sent."  So the question becomes "will it be a small
> > > enough change to detect if the upload-pack is driven by the daemon in the
> > > codepath J6t added 'if (!use_sideband)' to, and if so shouldn't we do
> > > so?"
> >
> > I don't think it is worth it at all.  The regression is purely cosmetic,
> > and I suspect you'll have a really hard time finding someone still using
> > those ancient git clients anyway.  Remember that such clients are unable
> > to fetch with HTTP from repositories using version 2 of the pack index
> > by default already.  That's why we created version 1.4.4.5.
> 
> Keep in mind that there could exist clients outside git.git that use modern
> pack-index or unpack-objects, but omit sideband support.

And that would be an abominable thing to make special support for such clients. If they're fancy enough to want progress display, they should comply with what moderately recent native git clients do and get sideband support.

Nicolas