git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] upload-pack: squelch progress indicator if client does not request sideband

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 16, 2009, 18:57 UTC
Message-ID
<7vski0c8gi.fsf@alter.siamese.dyndns.org>
In-Reply-To
<200906162041.16608.j6t@kdbg.org>
Johannes Sixt <j6t@kdbg.org> writes:
Show 15 quoted lines
> On Dienstag, 16. Juni 2009, Nicolas Pitre wrote:
> ...
>> I don't think it is worth it at all.  The regression is purely cosmetic,
>> and I suspect you'll have a really hard time finding someone still using
>> those ancient git clients anyway.  Remember that such clients are unable
>> to fetch with HTTP from repositories using version 2 of the pack index
>> by default already.  That's why we created version 1.4.4.5.
>
> Keep in mind that there could exist clients outside git.git that use modern
> pack-index or unpack-objects, but omit sideband support.
>
> I propose this patch instead, although the assumption that the --timeout
> option is only used by git-daemon may not be quite right. In this case it
> may be better to add a new option that sets the new flag and that
> git-daemon has to use.

Even though I tend to agree with Nico, this patch strikes a good balance with a very small impact. I am beginning to like it.

There _could_ be people who run fetch over git/ssh with custom --exec option that has --timeout in it. We _could_ teach --run-by-daemon option to the (daemon, upload-pack) pair in the same release (because it is reasonable to assume they come from the same vintage of git) to fix that case. But I do not think it is worth it. As Nico says, this is purely cosmetic.

Thanks.
Previous: Johannes SixtNext: Nicolas Pitre
Message 11 of 18 in “daemon: send stderr of service programs to the syslog”
  1. daemon: send stderr of service programs to the syslogJohannes Sixt, Jun 14, 2009
  2. Shawn O. PearceJun 15, 2009
  3. Nicolas PitreJun 15, 2009
  4. H. Peter AnvinJun 15, 2009
  5. upload-pack: squelch progress indicator if client does not request sidebandJohannes Sixt, Jun 15, 2009
  6. Junio C HamanoJun 15, 2009
  7. Nicolas PitreJun 16, 2009
  8. Junio C HamanoJun 16, 2009
  9. Nicolas PitreJun 16, 2009
  10. Johannes SixtJun 16, 2009
  11. Junio C HamanoJun 16, 2009
  12. Nicolas PitreJun 16, 2009
  13. Johannes SixtJun 15, 2009
  14. H. Peter AnvinJun 15, 2009
  15. Johannes SixtJun 16, 2009
  16. H. Peter AnvinJun 16, 2009
  17. Junio C HamanoJun 19, 2009
  18. Johannes SixtJun 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.