git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] daemon: send stderr of service programs to the syslog

From
Johannes Sixt <j6t@kdbg.org>
Date
Jun 15, 2009, 21:39 UTC
Message-ID
<200906152339.43607.j6t@kdbg.org>
In-Reply-To
<200906142238.51725.j6t@kdbg.org>
On Sonntag, 14. Juni 2009, Johannes Sixt wrote:
Show 5 quoted lines
>  I don't know whether service programs like upload-archive or upload-pack
>  write progress report to stderr or not, for example, if a client does not
>  support side-bands. In this case this patch is probably not enough since
>  this would fill the log with unneeded progress information. Any hints
>  are appreciated.

The progress indicator can be helped . But there is now another anoyance: If the client terminates the connection early, this is now logged as:

fatal: unable to run 'git-upload-pack'

The reason for this is that upload-pack is run as 'git upload-pack', which itself spawns the external 'git-upload-pack'. The latter dies from a SIGPIPE, and the former, in execv_dashed_external(), dutyfully writes this down.

The easiest solution is perhaps to make upload-pack a builtin.

BUT... The motivation, of which this patch is actually a fall-out, is to clean up the messy error behavor of the start,finish,run_command family. To take care of this error message is just one more (hopefully small) point on my agenda.

>  I intend to follow-up this patch with another one that integrates
>  run_service_command() in execute() in order to streamline how the
>  'incoming' fd is inherited to the service programs.

I'm not sure anymore whether the change I planned here is worth it. When I wrote this announcement, I had mis-remembered how daemon.c's handle() and execute() functions and --inetd mode interact.

-- Hannes
Previous: Nicolas PitreNext: H. Peter Anvin
Message 13 of 18 in “daemon: send stderr of service programs to the syslog”
  1. daemon: send stderr of service programs to the syslogJohannes Sixt, Jun 14, 2009
  2. Shawn O. PearceJun 15, 2009
  3. Nicolas PitreJun 15, 2009
  4. H. Peter AnvinJun 15, 2009
  5. upload-pack: squelch progress indicator if client does not request sidebandJohannes Sixt, Jun 15, 2009
  6. Junio C HamanoJun 15, 2009
  7. Nicolas PitreJun 16, 2009
  8. Junio C HamanoJun 16, 2009
  9. Nicolas PitreJun 16, 2009
  10. Johannes SixtJun 16, 2009
  11. Junio C HamanoJun 16, 2009
  12. Nicolas PitreJun 16, 2009
  13. Johannes SixtJun 15, 2009
  14. H. Peter AnvinJun 15, 2009
  15. Johannes SixtJun 16, 2009
  16. H. Peter AnvinJun 16, 2009
  17. Junio C HamanoJun 19, 2009
  18. Johannes SixtJun 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.