Re: [PATCH] upload-pack: squelch progress indicator if client does not request sideband

From: Nicolas Pitre <nico@cam.org>
Date: Jun 16, 2009, 01:16 UTC
Message-ID: <alpine.LFD.2.00.0906152109240.16467@xanadu.home>
In-Reply-To: <7vski1i2ov.fsf@alter.siamese.dyndns.org>

On Mon, 15 Jun 2009, Junio C Hamano wrote:

Show 14 quoted lines

> I think it is a very good idea to squelch progress output that will never
> go to the client (it will be wasted traffic, regardless of the "syslog"
> thing), but
> 
>  (1) Is "not using sideband" the same as "client won't see the progress
>      output" for all vintages of clients that work with the current
>      server?
> 
>      How did we drive upload-pack over native or ssh connection before we
>      introduced sideband?  I vaguely recall that we relied on stderr going
>      to the invoking terminal in the local case.  With this change, does
>      the user suddenly stop seeing progress if the client is older than
>      583b7ea (upload-pack/fetch-pack: support side-band communication,
>      2006-06-21)?  If so, that would be a regression.

Native, or git:// style, certainly never was able to get any kind of progress display without sideband support.

As to old clients using ssh... well... that could be a regression. But do we really care? This is pre v1.4.1 after all, and even the previous Debian stable was using a later git version.

Nicolas