Re: [PATCH] index-pack: correctly initialize appended objects

From: Nicolas Pitre <nico@cam.org>
Date: Jul 25, 2008, 11:48 UTC
Message-ID: <alpine.LFD.1.10.0807250742120.9968@xanadu.home>
In-Reply-To: <alpine.DEB.1.00.0807241821440.8986@racer>

On Thu, 24 Jul 2008, Johannes Schindelin wrote:

Show 22 quoted lines

> 
> From: Björn Steinbrink <B.Steinbrink@gmx.de>
> 
> When index-pack completes a thin pack it appends objects to the pack.  
> Since the commit 92392b4(index-pack: Honor core.deltaBaseCacheLimit when 
> resolving deltas) such an object can be pruned in case of memory
> pressure.
> 
> To be able to re-read the object later, a few more fields have to be set.
> 
> Noticed by Pierre Habouzit.
> 
> Hopefully-signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
> Hopefully-reviewed-and-signed-off-by: Nicolas Pitre <nico@cam.org>, 
> 
> --
> 
> 	This was probably missed in the flurry of patches, scratched 
> 	patches, and new patches.
> 
> 	Nico could you have a quick look?  (I would ask Shawn, but I know 
> 	that he is pretty busy with real world issues.)

sorry, I have intermitant connectivity this week, and I'll be off the net for two weeks after that.

Yes, this looks fine, although I'd add a comment mentioning that those extra fields are uninitialized in the thin pack case when objects are appended to the pack since they're already initialized otherwise.

ACK.

Nicolas