git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] index-pack: correctly initialize appended objects

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 24, 2008, 17:32 UTC
Message-ID
<alpine.DEB.1.00.0807241821440.8986@racer>
From: Björn Steinbrink <B.Steinbrink@gmx.de>

When index-pack completes a thin pack it appends objects to the pack. Since the commit 92392b4(index-pack: Honor core.deltaBaseCacheLimit when resolving deltas) such an object can be pruned in case of memory pressure.

To be able to re-read the object later, a few more fields have to be set.
Noticed by Pierre Habouzit.
Hopefully-signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
Hopefully-reviewed-and-signed-off-by: Nicolas Pitre <nico@cam.org>, 
--
	This was probably missed in the flurry of patches, scratched 
	patches, and new patches.
	Nico could you have a quick look?  (I would ask Shawn, but I know 
	that he is pretty busy with real world issues.)
diff --git a/index-pack.c b/index-pack.c
index ac20a46..33ba8ef 100644
--- a/index-pack.c
+++ b/index-pack.c
@@ -699,6 +699,9 @@ static struct object_entry *append_obj_to_pack(
 	write_or_die(output_fd, header, n);
 	obj[0].idx.crc32 = crc32(0, Z_NULL, 0);
 	obj[0].idx.crc32 = crc32(obj[0].idx.crc32, header, n);
+	obj[0].hdr_size = n;
+	obj[0].type = type;
+	obj[0].size = size;
 	obj[1].idx.offset = obj[0].idx.offset + n;
 	obj[1].idx.offset += write_compressed(output_fd, buf, size, &obj[0].idx.crc32);
 	hashcpy(obj->idx.sha1, sha1);
Next: Björn Steinbrink
Message 1 of 15 in “index-pack: correctly initialize appended objects”
  1. index-pack: correctly initialize appended objectsJohannes Schindelin, Jul 24, 2008
  2. Björn SteinbrinkJul 24, 2008
  3. Junio C HamanoJul 25, 2008
  4. Johannes SchindelinJul 25, 2008
  5. Nicolas PitreJul 25, 2008
  6. Björn SteinbrinkJul 25, 2008
  7. Nicolas PitreJul 25, 2008
  8. Junio C HamanoJul 25, 2008
  9. Björn SteinbrinkJul 25, 2008
  10. Johannes SchindelinJul 25, 2008
  11. Shawn O. PearceJul 25, 2008
  12. index-pack: correctly initialize appended objectsBjörn Steinbrink, Jul 25, 2008
  13. Shawn O. PearceJul 25, 2008
  14. Johannes SchindelinJul 26, 2008
  15. Nicolas PitreJul 25, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.