Re: [PATCH] index-pack: correctly initialize appended objects

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 25, 2008, 13:15 UTC
Message-ID: <alpine.DEB.1.00.0807251513240.11976@eeepc-johanness>
In-Reply-To: <20080725115519.GA32487@atjola.homenet>

Hi,

On Fri, 25 Jul 2008, Björn Steinbrink wrote:

Show 14 quoted lines

> On 2008.07.24 22:21:14 -0700, Junio C Hamano wrote:
> > Reading get_data_from_pack(), it does rely on hdr_size, idx.offset and 
> > idx.offset of the next entry to be set correctly.  The function does 
> > not seem to use type (which the patch is also setting) nor real_type 
> > (which the patch does not set).
> 
> type is used in get_base_data().
> 
> > However, the code checks objects[nth].real_type all over the place in 
> > the code.  Doesn't the lack of real_type assignment in 
> > append_obj_to_pack() affect them in any way?
> 
> I had thought that resolve_delta() would set that, but it seems that we 
> never call that function like that. Hm...

So, let's add the comment as Nico suggested, and set real_type, too? (And it would be smashing if you could verify that the type is indeed correctly set to non-delta...)

I think that setting real_type is necessary to have less surprises when the code is extended in the future.

Thanks, Dscho