Re: [PATCH] index-pack: correctly initialize appended objects

From: Björn Steinbrink <b.steinbrink@gmx.de>
Date: Jul 25, 2008, 11:55 UTC
Message-ID: <20080725115519.GA32487@atjola.homenet>
In-Reply-To: <7vy73q4jzp.fsf@gitster.siamese.dyndns.org>

On 2008.07.24 22:21:14 -0700, Junio C Hamano wrote:

> Reading get_data_from_pack(), it does rely on hdr_size, idx.offset and
> idx.offset of the next entry to be set correctly.  The function does not
> seem to use type (which the patch is also setting) nor real_type (which
> the patch does not set).

type is used in get_base_data().

> However, the code checks objects[nth].real_type all over the place in the
> code.  Doesn't the lack of real_type assignment in append_obj_to_pack()
> affect them in  any way?

I had thought that resolve_delta() would set that, but it seems that we never call that function like that. Hm...

Björn