Re: Corrupted (?) commit 6e6db85e confusing gitk
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Dec 2, 2007, 21:49 UTC
- Message-ID
- <alpine.LFD.0.9999.0712021348020.8458@woody.linux-foundation.org>
- In-Reply-To
- <Pine.LNX.4.64.0712022132060.27959@racer.site>
On Sun, 2 Dec 2007, Johannes Schindelin wrote:
> > Darn. But when can "GIT_AUTHOR_DATE" be set to the empty string? I mean, > I understand unset'ing it. But setting it to ""?
Well, regardless, I think we should make sure that git-commit-tree never writes out an invalid commit - no matter *how* insane input it gets. Making it complain loudly (with a 'die("Oh, no, you don't!")') would be a good idea.
Linus