[PATCH] gitk: Add workaround to handle corrupted author date

From: Steffen Prohaska <prohaska@zib.de>
Date: Dec 2, 2007, 16:36 UTC
Message-ID: <1196613383337-git-send-email-prohaska@zib.de>
In-Reply-To: <5F1A20CC-7427-4E7A-AB95-E89C9FA17951@zib.de>

6e6db85ea9423eea755cf5acf7a563c0d9559063 contains a corrupted author line, which is lacking the time and timezone information.

This commit adds a workaround to handle this situation.  If the
time cannot be parsed, it is assumed to be 0 and the full line
is assumed to be the author's name.
---
 gitk |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

This works around the issue for me. However, I don't think this patch should be applied.

The best was if such a corrupted commit wouldn't enter the repository in the first place. But once it is there, I think git should verify the format of a commit and report an approriate error. gitk could continue to assume well formed commits.

    Steffen

diff --git a/gitk b/gitk
index 1da0b0a..873766c 100755
--- a/gitk
+++ b/gitk
@@ -439,7 +439,12 @@ proc parsecommit {id contents listed} {
 	set tag [lindex $line 0]
 	if {$tag == "author"} {
 	    set audate [lindex $line end-1]
-	    set auname [lrange $line 1 end-2]
+	    if {[catch {formatdate $audate}]} {
+		set audate 0
+		set auname [lrange $line 1 end]
+	    } else {
+		set auname [lrange $line 1 end-2]
+	    }
 	} elseif {$tag == "committer"} {
 	    set comdate [lindex $line end-1]
 	    set comname [lrange $line 1 end-2]

-- 
1.5.3.7.949.g2221a6