Re: Corrupted (?) commit 6e6db85e confusing gitk

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Dec 2, 2007, 20:34 UTC
Message-ID: <alpine.LFD.0.9999.0712021229300.8458@woody.linux-foundation.org>
In-Reply-To: <20071202193918.GQ6212@lavos.net>

On Sun, 2 Dec 2007, Brian Downing wrote:

Show 7 quoted lines

>
> With the above, something like:
> 
> echo msg | GIT_AUTHOR_DATE='' git commit-tree sha1
> 
> will produce a broken commit without a timestamp, since fmt_ident is
> also used for the committer and author lines.

Ouch. And I notice that fsck doesn't even warn about the resulting broken commit. Partly because I was lazy, but partly because originally I was thinking that maybe we'll have more header lines, so fsck basically just checks the ones that git *really* cares about (parenthood and tree), and the rest is not really even looked at (well, it does check that the next line starts with "author", but that's it).

I guess the breakage is pretty benign, but this is still very wrong.

Junio: that broken commit seems to be in "pu" only - we should make sure 
that it never makes it into next or master, so that it will eventually get 
pruned out of history.

		Linus