Re: Corrupted (?) commit 6e6db85e confusing gitk

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 2, 2007, 22:36 UTC
Message-ID: <7vbq98u3l1.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.0.9999.0712021348020.8458@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 9 quoted lines

> On Sun, 2 Dec 2007, Johannes Schindelin wrote:
>> 
>> Darn.  But when can "GIT_AUTHOR_DATE" be set to the empty string?  I mean, 
>> I understand unset'ing it.  But setting it to ""?
>
> Well, regardless, I think we should make sure that git-commit-tree never 
> writes out an invalid commit - no matter *how* insane input it gets. 
> Making it complain loudly (with a 'die("Oh, no, you don't!")') would be a 
> good idea.

FWIW, fmt_ident() records the current time (before the kh/commit series, and after the fix I sent on top of kh/commit series), which may be a reasonable alternative.