Re: FFmpeg considering GIT

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: May 5, 2007, 22:18 UTC
Message-ID: <alpine.LFD.0.98.0705051511020.17381@woody.linux-foundation.org>
In-Reply-To: <alpine.LFD.0.98.0705051019580.3819@woody.linux-foundation.org>

On Sat, 5 May 2007, Linus Torvalds wrote:

Show 7 quoted lines

> 
> This patch may be worth applying regardless, since there is really no real 
> reason to use "git rev-list". In fact, I really like the ability to say
> 
> 	gitk --stat
> 
> and have the diffstat output visible in the commit window automatically ;)

Btw, testing this a bit more actually shows what I would consider a real buglet in "git log --boundary": the option would be honoured only if "left-right" was enabled.

This patch fixes "git log --boundary" to actually show the "-" in front of a commit name regardless of whether you _also_ asked for left-right.

(It also shows that my "gitk" patch was incorrectly getting the commit name from character 6 onward, even though it should have been 7, but I'll also try to make gitk understand the "<" and ">" markers, and make it possible to say

	gitk --left-right a...b

and have the commits colored appropriately. That would be cool, but it might need more tcl/tk knowledge than I actually possess).

		Linus

---

diff --git a/log-tree.c b/log-tree.c
index c679324..4bef909 100644
--- a/log-tree.c
+++ b/log-tree.c
@@ -244,10 +244,10 @@ void show_log(struct rev_info *opt, const char *sep)
 		      stdout);
 		if (opt->commit_format != CMIT_FMT_ONELINE)
 			fputs("commit ", stdout);
-		if (opt->left_right) {
-			if (commit->object.flags & BOUNDARY)
-				putchar('-');
-			else if (commit->object.flags & SYMMETRIC_LEFT)
+		if (commit->object.flags & BOUNDARY)
+			putchar('-');
+		else if (opt->left_right) {
+			if (commit->object.flags & SYMMETRIC_LEFT)
 				putchar('<');
 			else
 				putchar('>');