git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Use DIFF_XDL_SET/DIFF_OPT_SET instead of raw bit-masking

From
Keith Cascio <keith@cs.ucla.edu>
Date
Feb 17, 2009, 17:33 UTC
Message-ID
<alpine.GSO.2.00.0902170918180.27811@kiwi.cs.ucla.edu>
In-Reply-To
<alpine.DEB.1.00.0902171304130.6185@intel-tinevez-2-302>
Dscho,
On Tue, 17 Feb 2009, Johannes Schindelin wrote:
> Rationale?
> If you are going to add something on top of that, I can understand that, but 
> this patch is not labeled [1/n].  And...

This patch is about consistency. Yes I'd like to add something on top of it. But these improvements stand well on their own. My work on the diff.defaultOptions patch highlighted the desirability of handling these bit manipulations consistently, via macros.

> ... this does not look good to me, without a compelling reason why we want to 
> have the patch nevertheless.
Is there something you dislike about the code style?  As always I'm happy to 
adjust it.
                                    -- Keith
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 3 of 8 in “Use DIFF_XDL_SET/DIFF_OPT_SET instead of raw bit-masking”
  1. Use DIFF_XDL_SET/DIFF_OPT_SET instead of raw bit-maskingKeith Cascio, Feb 17, 2009
  2. Johannes SchindelinFeb 17, 2009
  3. Keith CascioFeb 17, 2009
  4. Johannes SchindelinFeb 17, 2009
  5. Keith CascioFeb 18, 2009
  6. Johannes SchindelinFeb 18, 2009
  7. Keith CascioFeb 18, 2009
  8. Jeff KingFeb 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.