Re: [PATCH] Use DIFF_XDL_SET/DIFF_OPT_SET instead of raw bit-masking

From: Keith Cascio <keith@cs.ucla.edu>
Date: Feb 18, 2009, 22:59 UTC
Message-ID: <alpine.GSO.2.00.0902181437260.6181@kiwi.cs.ucla.edu>
In-Reply-To: <alpine.DEB.1.00.0902182219370.10279@pacific.mpi-cbg.de>

On Wed, 18 Feb 2009, Johannes Schindelin wrote:

Show 8 quoted lines

> Okay, you asked for it.  I tried to be gentle.
> 
> I see _no_ value in your changes, and the diffstat as a _very_ real downside.
> 
> If the code would become clearer with your patch, I would not mind.  But I 
> find that the result is not more readable than the original.
> 
> As part of a parse-optification, I would not mind.  But before that, no.

Actually I appreciate your feedback, and the more direct the better. The chief value I see in revising the code to accomplish these bit settings uniformly using well known macros is that later, if someone has good reason to extend the macro so it results in some new side effect, e.g. to update a dirty bit mask, the new behavior automatically cascades to every appropriate use out there in the code. A macro is essentially a "code constant". As with other constants, the benefit comes from defining it once and using it everywhere. Is this effect not worth as much as I think it is? Is there a hidden gotcha in my ideal? Or does anyone else see value here? Please speak up!

                                             -- Keith