From: Keith Cascio <keith@cs.ucla.edu>
Date: Tue, 17 Feb 2009 17:33:42 GMT
Subject: Re: [PATCH] Use DIFF_XDL_SET/DIFF_OPT_SET instead of raw bit-masking
Message-ID: <alpine.GSO.2.00.0902170918180.27811@kiwi.cs.ucla.edu>
In-Reply-To: <alpine.DEB.1.00.0902171304130.6185@intel-tinevez-2-302>

Dscho,

On Tue, 17 Feb 2009, Johannes Schindelin wrote:

> Rationale?
> If you are going to add something on top of that, I can understand that, but 
> this patch is not labeled [1/n].  And...

This patch is about consistency.  Yes I'd like to add something on top of it.  
But these improvements stand well on their own.  My work on the 
diff.defaultOptions patch highlighted the desirability of handling these bit 
manipulations consistently, via macros.

> ... this does not look good to me, without a compelling reason why we want to 
> have the patch nevertheless.

Is there something you dislike about the code style?  As always I'm happy to 
adjust it.
                                    -- Keith