git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Use DIFF_XDL_SET/DIFF_OPT_SET instead of raw bit-masking

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 17, 2009, 22:57 UTC
Message-ID
<alpine.DEB.1.00.0902172354570.10279@pacific.mpi-cbg.de>
In-Reply-To
<alpine.GSO.2.00.0902170918180.27811@kiwi.cs.ucla.edu>
Hi,
On Tue, 17 Feb 2009, Keith Cascio wrote:
> On Tue, 17 Feb 2009, Johannes Schindelin wrote:
> 
> But these improvements stand well on their own.

That was my point; without anything on top I would not like to risk regressions that easily.

Show 5 quoted lines
> > ... this does not look good to me, without a compelling reason why we 
> > want to have the patch nevertheless.
> 
> Is there something you dislike about the code style?  As always I'm 
> happy to adjust it.

If you had not so conveniently clipped what I quoted just before the three dots, I could point out that it adds roughly double the number of lines as it removes.

Ciao, Dscho

Previous: Keith CascioNext: Keith Cascio
Message 4 of 8 in “Use DIFF_XDL_SET/DIFF_OPT_SET instead of raw bit-masking”
  1. Use DIFF_XDL_SET/DIFF_OPT_SET instead of raw bit-maskingKeith Cascio, Feb 17, 2009
  2. Johannes SchindelinFeb 17, 2009
  3. Keith CascioFeb 17, 2009
  4. Johannes SchindelinFeb 17, 2009
  5. Keith CascioFeb 18, 2009
  6. Johannes SchindelinFeb 18, 2009
  7. Keith CascioFeb 18, 2009
  8. Jeff KingFeb 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.