Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 8, 2017, 11:35 UTC
Message-ID: <alpine.DEB.2.21.1.1705081334440.146734@virtualbox>
In-Reply-To: <CACBZZX6_GbqNpTXTB8UQJzvD2nx_UTN8fwHV8Aczg+b9XoO_tg@mail.gmail.com>

Hi,

On Sat, 6 May 2017, Ævar Arnfjörð Bjarmason wrote:

Show 23 quoted lines

> On Sat, May 6, 2017 at 12:30 AM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> > Hi Daniel,
> >
> >
> > On Fri, 5 May 2017, Daniel Ferreira wrote:
> >> +static void print_modified(void)
> >> +{
> >> +     int i;
> >> +     struct add_interactive_status s;
> >> +     const char *modified_fmt = _("%12s %12s %s");
> >
> > We cannot really translate that...
> 
> He copied this from the *.perl code:
> 
>     # TRANSLATORS: you can adjust this to align "git add -i" status menu
>     my $status_fmt = __('%12s %12s %s');
> 
> And one translation at least makes use of that (and probably others should).
> 
> But porting the /* TRANSLATORS: ... */ comment over is missing, and
> should be added.

Ah, that explains it. It still is not really translateable, but with the comment, even *I* understand why it is marked for translation.

Thanks, Dscho