Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 5, 2017, 21:21 UTC
Message-ID: <alpine.DEB.2.21.1.1705052320270.146734@virtualbox>
In-Reply-To: <20170505201621.25560-1-avarab@gmail.com>

Hi,

On Fri, 5 May 2017, Ævar Arnfjörð Bjarmason wrote:

Show 12 quoted lines

>  int cmd_add_interactive__helper(int argc, const char **argv, const char *prefix)
>  {
> -	int i, found_opt = 0;
> -
> -	git_config(git_add_interactive_config, NULL);
> +	int opt_status = 0;
>  
> -	for (i = 1; i < argc; i++) {
> -		const char *arg = argv[i];
> +	struct option options[] = {
> +		OPT_BOOL(0, "status", &opt_status,
> +			 N_("print status information with diffstat")),

Please use OPT_CMDMODE() instead; it was invented exactly for this kind of scenario.

> -- 
> 2.11.0

Really? ;-)

Ciao, Dscho