Re: [PATCH 1/3] diff: export diffstat interface

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 5, 2017, 21:28 UTC
Message-ID: <alpine.DEB.2.21.1.1705052326520.146734@virtualbox>
In-Reply-To: <1494009820-2090-2-git-send-email-bnmvco@gmail.com>

Hi Daniel,

On Fri, 5 May 2017, Daniel Ferreira wrote:

Show 9 quoted lines

> Make the diffstat interface (namely, the diffstat_t struct and
> diff_flush_stat) no longer be internal to diff.c and allow it to be used
> by other parts of git.
> 
> This is helpful for code that may want to easily extract information
> from files using the diff machinery, while flushing it differently from
> how the show_* functions used by diff_flush() do it.
> 
> Signed-off-by: Daniel Ferreira <bnmvco@gmail.com>

Maybe add one more paragraph with the motivation, i.e. the conversion of add -i into a builtin?

The patch is straight-forward, and I do not even see any names that may need to be adjusted for a more visible API than a file-local function.

> -- 
> 2.7.4 (Apple Git-66)

I guess I take my comment about Ævar's Git version back ;-)

Ciao, Johannes