Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: May 5, 2017, 22:09 UTC
Message-ID: <CACBZZX7LgTLHprSoc5ng47GO8vv+HLJXcu7a+bTkR5kB=NfUjg@mail.gmail.com>
In-Reply-To: <alpine.DEB.2.21.1.1705052320270.146734@virtualbox>

On Fri, May 5, 2017 at 11:21 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 19 quoted lines

> Hi,
>
> On Fri, 5 May 2017, Ævar Arnfjörð Bjarmason wrote:
>
>>  int cmd_add_interactive__helper(int argc, const char **argv, const char *prefix)
>>  {
>> -     int i, found_opt = 0;
>> -
>> -     git_config(git_add_interactive_config, NULL);
>> +     int opt_status = 0;
>>
>> -     for (i = 1; i < argc; i++) {
>> -             const char *arg = argv[i];
>> +     struct option options[] = {
>> +             OPT_BOOL(0, "status", &opt_status,
>> +                      N_("print status information with diffstat")),
>
> Please use OPT_CMDMODE() instead; it was invented exactly for this kind of
> scenario.

Indeed. Forgot about that. That's much better.

>> --
>> 2.11.0
>
> Really? ;-)

CC-ing the Debian stretch release team with your complaint [not really].

I don't bother to 'make install' the git I'm hacking on, so E-Mail gets sent with whatever's in Debian testing.