Re: [PATCH] git-stash: Don't GPG sign when stashing changes

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 14, 2016, 15:50 UTC
Message-ID: <alpine.DEB.2.20.1604141748370.2967@virtualbox>
In-Reply-To: <CAOAY-+1TztY95z3Yi34HB3aYUG5aOHKK9G3OmpYM41ugDMtJUA@mail.gmail.com>

Hi Cameron,

On Wed, 13 Apr 2016, Cameron Currie wrote:

Show 17 quoted lines

> > > On Thu, 7 Apr 2016, daurnimator wrote:
> > >
> > >> Cameron Currie <me <at> cameroncurrie.net> writes:
> > >> > This is helpful for folks with commit.gpgsign = true in their
> > >> > .gitconfig.
> > >>
> > >> > https://github.com/git/git/pull/186
> > >>
> > >> I too would like this.
> > >> Bumping due to lack of attention.
> > >
> > > It lacks a Sign-off, our convention is to continue in lower-case
> > > after the colon in the commit's subject, and I think that it would
> > > be good to write so much as one paragraph in the commit message.
>
> I don't think I can find the time right now. Feel free to rewrite the
> commit message to match convention.

I am afraid that it would be improper for anybody to add your Sign-off, as it is *your* statement that you are indeed contributing this as Open Source, and that you indeed are free to do so.

If you do not find the time to take care of these small changes, I fear the Git maintainer will *have* to drop your patch to avoid hassle for himself.

Ciao, Johannes