Re: [PATCH v2] git-stash: Don't GPG sign when stashing changes

From: Junio C Hamano <gitster@pobox.com>
Date: May 3, 2016, 01:21 UTC
Message-ID: <CAPc5daXVBJ=2KJfqcdwyH1Eq54vw-QeOEBF1aGj2dn+Yihcy9A@mail.gmail.com>
In-Reply-To: <CAEnbY+cu9E8DYGcg8FoK37NGZXbhSKvzVwMpLUEspXRYpPUdaA@mail.gmail.com>

On Mon, May 2, 2016 at 4:56 PM, Daurnimator <quae@daurnimator.com> wrote:

Show 5 quoted lines

> On 3 May 2016 at 07:57, Junio C Hamano <gitster@pobox.com> wrote:
>
> I agree quiltimport should not, but I think filter-branch possibly
> should... at least for your *own* commits.
> I often think of filter-branch as an "advanced" `git commit --amend`

But it does not do the gpgsign thing only for your own commits right now, and even if it did, you would not necessarily want it to always use the configured setting. That means that the command, if it wants to work well with the signed commits, must learn to honor command line option to enable or disable passing --gpgsign option to underlying commit-tree *anyway*.

So I think it is a right thing to fix commit-tree to ignore commit.gpgsign at least by default.