git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] git-stash: Don't GPG sign when stashing changes

From
DDaurnimator <quae@daurnimator.com>
Date
May 6, 2016, 06:06 UTC
Message-ID
<CAEnbY+cAzLKw9GJTWy5ZP4rGsve161qSX5DgqWimcC5kYRqkyA@mail.gmail.com>
In-Reply-To
<CAPc5daXVBJ=2KJfqcdwyH1Eq54vw-QeOEBF1aGj2dn+Yihcy9A@mail.gmail.com>
On 3 May 2016 at 11:21, Junio C Hamano <gitster@pobox.com> wrote:
Show 16 quoted lines
> On Mon, May 2, 2016 at 4:56 PM, Daurnimator <quae@daurnimator.com> wrote:
>> On 3 May 2016 at 07:57, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> I agree quiltimport should not, but I think filter-branch possibly
>> should... at least for your *own* commits.
>> I often think of filter-branch as an "advanced" `git commit --amend`
>
> But it does not do the gpgsign thing only for your own commits right now, and
> even if it did, you would not necessarily want it to always use the configured
> setting. That means that the command, if it wants to work well with the signed
> commits, must learn to honor command line option to enable or disable passing
> --gpgsign option to underlying commit-tree *anyway*.
>
> So I think it is a right thing to fix commit-tree to ignore
> commit.gpgsign at least
> by default.

Okay, that makes sense. Will you work on a patch?

Previous: Junio C HamanoNext: Johannes Schindelin
Message 10 of 12 in “git-stash: Don't GPG sign when stashing changes”
  1. git-stash: Don't GPG sign when stashing changesCameron Currie, Nov 6, 2015
  2. Junio C HamanoNov 6, 2015
  3. daurnimatorApr 7, 2016
  4. Johannes SchindelinApr 7, 2016
  5. DaurnimatorApr 12, 2016
  6. git-stash: Don't GPG sign when stashing changesCameron Currie, May 2, 2016
  7. Junio C HamanoMay 2, 2016
  8. DaurnimatorMay 2, 2016
  9. Junio C HamanoMay 3, 2016
  10. DaurnimatorMay 6, 2016
  11. Johannes SchindelinApr 14, 2016
  12. DaurnimatorMay 2, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.