git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-stash: Don't GPG sign when stashing changes

From
DDaurnimator <quae@daurnimator.com>
Date
May 2, 2016, 06:06 UTC
Message-ID
<CAEnbY+fG60mZSKs_d8Lpyb2Czf=UfA9cKOBTtEjEXeUfGE9zLg@mail.gmail.com>
In-Reply-To
<alpine.DEB.2.20.1604141748370.2967@virtualbox>

On 15 April 2016 at 01:50, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 32 quoted lines
> Hi Cameron,
>
> On Wed, 13 Apr 2016, Cameron Currie wrote:
>
>> > > On Thu, 7 Apr 2016, daurnimator wrote:
>> > >
>> > >> Cameron Currie <me <at> cameroncurrie.net> writes:
>> > >> > This is helpful for folks with commit.gpgsign = true in their
>> > >> > .gitconfig.
>> > >>
>> > >> > https://github.com/git/git/pull/186
>> > >>
>> > >> I too would like this.
>> > >> Bumping due to lack of attention.
>> > >
>> > > It lacks a Sign-off, our convention is to continue in lower-case
>> > > after the colon in the commit's subject, and I think that it would
>> > > be good to write so much as one paragraph in the commit message.
>>
>> I don't think I can find the time right now. Feel free to rewrite the
>> commit message to match convention.
>
> I am afraid that it would be improper for anybody to add your Sign-off, as
> it is *your* statement that you are indeed contributing this as Open
> Source, and that you indeed are free to do so.
>
> If you do not find the time to take care of these small changes, I fear
> the Git maintainer will *have* to drop your patch to avoid hassle for
> himself.
>
> Ciao,
> Johannes

Cameron, could you please add a sign off to your commit? It should be as simple as running `git commit --amend -s`

Previous: Johannes Schindelin
Message 12 of 12 in “git-stash: Don't GPG sign when stashing changes”
  1. git-stash: Don't GPG sign when stashing changesCameron Currie, Nov 6, 2015
  2. Junio C HamanoNov 6, 2015
  3. daurnimatorApr 7, 2016
  4. Johannes SchindelinApr 7, 2016
  5. DaurnimatorApr 12, 2016
  6. git-stash: Don't GPG sign when stashing changesCameron Currie, May 2, 2016
  7. Junio C HamanoMay 2, 2016
  8. DaurnimatorMay 2, 2016
  9. Junio C HamanoMay 3, 2016
  10. DaurnimatorMay 6, 2016
  11. Johannes SchindelinApr 14, 2016
  12. DaurnimatorMay 2, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.