git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t6302: drop unnecessary GPG requirement

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 2, 2016, 07:06 UTC
Message-ID
<alpine.DEB.2.20.1602020805280.2964@virtualbox>
In-Reply-To
<xmqq4mdsw949.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Mon, 1 Feb 2016, Junio C Hamano wrote:
Show 11 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > An even easier solution might be to *not* set up the signed tags in the
> > 'setup' part, but only in the respective test case, and delete them right
> > away after said test case?
> 
> After reading your patch, I do not find it an "easier solution", at
> least with the definition of the word "solution" I would use.  It
> stops testing signed or doubly signed tags everywhere, assuming that
> future regressions can ever break only --points-at tests and no
> other tests around signed tags.
True.
Show 9 quoted lines
> > Something like this (I even tested this with and without the GPG prereq):
> > ...
> > -test_expect_success 'check signed tags with --points-at' '
> > +test_expect_success GPG 'check signed tags with --points-at' '
> > +	git tag -s -m "A signed tag message" signed-tag side &&
> > +	git tag -s -m "Annonated doubly" double-tag signed-tag &&
> > +	test_when_finished git tag -d signed-tag &&
> 
> Interestingly, double-tag is not removed here.
Whooopsie.
I retract the patch in any case ;-)

Ciao, Dscho

Previous: Junio C Hamano
Message 5 of 5 in “t6302: drop unnecessary GPG requirement”
  1. t6302: drop unnecessary GPG requirementEric Sunshine, Jan 31, 2016
  2. Junio C HamanoFeb 1, 2016
  3. Johannes SchindelinFeb 1, 2016
  4. Junio C HamanoFeb 1, 2016
  5. Johannes SchindelinFeb 2, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.