Re: [PATCH] t6302: drop unnecessary GPG requirement
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 1, 2016, 18:58 UTC
- Message-ID
- <xmqq4mdsw949.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <alpine.DEB.2.20.1602010759480.2964@virtualbox>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> An even easier solution might be to *not* set up the signed tags in the > 'setup' part, but only in the respective test case, and delete them right > away after said test case?
After reading your patch, I do not find it an "easier solution", at least with the definition of the word "solution" I would use. It stops testing signed or doubly signed tags everywhere, assuming that future regressions can ever break only --points-at tests and no other tests around signed tags. The easiest solution along that same line of thought taken to the extreme would be to say test_done without having any test ;-)
The "filter entries about signed tags from the expected output" approach I suggested would not work if the expected output files are not line oriented and lines that would appear only when signed tags are tested cannot be easily filtered out (like with the sed script in the message you are responding to), but I think for the existing test cases (with or without additions of annotated but unsigned tags) it would work.
Show 7 quoted lines
> Something like this (I even tested this with and without the GPG prereq): > ... > -test_expect_success 'check signed tags with --points-at' ' > +test_expect_success GPG 'check signed tags with --points-at' ' > + git tag -s -m "A signed tag message" signed-tag side && > + git tag -s -m "Annonated doubly" double-tag signed-tag && > + test_when_finished git tag -d signed-tag &&
Interestingly, double-tag is not removed here.