[PATCH] t6302: drop unnecessary GPG requirement
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jan 31, 2016, 20:19 UTC
- Message-ID
- <1454271562-24291-1-git-send-email-sunshine@sunshineco.com>
These tests are concerned specifically with filtering, sorting, formatting behavior of git-for-each-ref, yet if GPG is not present, the entire test script is skipped even though none of the tests depend upon or care whether the tags are signed. This unnecessary dependency upon GPG may prevent these tests from being more widely run, so drop it.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> ---
I noticed this while reviewing[1] v3 of Karthik's "optimize ref-filter.c:populate_value()" series when I tried to run tests the series added but couldn't due to missing GPG.
[1]: http://article.gmane.org/gmane.comp.version-control.git/284766
t/t6302-for-each-ref-filter.sh | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/t/t6302-for-each-ref-filter.sh b/t/t6302-for-each-ref-filter.sh index fe4796c..dea2a9e 100755 --- a/t/t6302-for-each-ref-filter.sh +++ b/t/t6302-for-each-ref-filter.sh @@ -3,13 +3,6 @@ test_description='test for-each-refs usage of ref-filter APIs' . ./test-lib.sh -. "$TEST_DIRECTORY"/lib-gpg.sh - -if ! test_have_prereq GPG -then - skip_all="skipping for-each-ref tests, GPG not available" - test_done -fi test_expect_success 'setup some history and refs' ' test_commit one && @@ -17,8 +10,8 @@ test_expect_success 'setup some history and refs' ' test_commit three && git checkout -b side && test_commit four && - git tag -s -m "A signed tag message" signed-tag && - git tag -s -m "Annonated doubly" double-tag signed-tag && + git tag -m "A signed tag message" signed-tag && + git tag -m "Annonated doubly" double-tag signed-tag && git checkout master && git update-ref refs/odd/spot master '
-- 2.7.0.333.g9c3d022