From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 02 Feb 2016 07:06:18 GMT
Subject: Re: [PATCH] t6302: drop unnecessary GPG requirement
Message-ID: <alpine.DEB.2.20.1602020805280.2964@virtualbox>
In-Reply-To: <xmqq4mdsw949.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Mon, 1 Feb 2016, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > An even easier solution might be to *not* set up the signed tags in the
> > 'setup' part, but only in the respective test case, and delete them right
> > away after said test case?
> 
> After reading your patch, I do not find it an "easier solution", at
> least with the definition of the word "solution" I would use.  It
> stops testing signed or doubly signed tags everywhere, assuming that
> future regressions can ever break only --points-at tests and no
> other tests around signed tags.

True.

> > Something like this (I even tested this with and without the GPG prereq):
> > ...
> > -test_expect_success 'check signed tags with --points-at' '
> > +test_expect_success GPG 'check signed tags with --points-at' '
> > +	git tag -s -m "A signed tag message" signed-tag side &&
> > +	git tag -s -m "Annonated doubly" double-tag signed-tag &&
> > +	test_when_finished git tag -d signed-tag &&
> 
> Interestingly, double-tag is not removed here.

Whooopsie.

I retract the patch in any case ;-)

Ciao,
Dscho