Re: [PATCH] completion: add missing configuration variables
- From
Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
- Date
- Dec 16, 2010, 07:14 UTC
- Message-ID
- <alpine.DEB.1.10.1012160810440.25560@debian>
- In-Reply-To
- <20101216124235.GA32636@neumann>
On Thu, 16 Dec 2010, SZEDER G?bor wrote:
Show 13 quoted lines
> Hi, > > > On Wed, Dec 15, 2010 at 08:44:45PM +0100, Martin von Zweigbergk wrote: > > On Wed, 15 Dec 2010, Jeff King wrote: > > > As an aside, I would think "--unset" should actually choose from the set > > > of configured variables for completion (i.e., "git config --list | cut > > > -d= -f1"). But that would obviously be a separate patch. > > > > Good point. I'll put it on my todo. > > It already works that way since 0065236 (bash completion: complete > variable names for "git config" with options, 2009-05-08).
Nice. Thanks. Removed from my todo :-). Then I don't see any reason at all to keep color.grep.external and add.ignore-errors.
/Martin