Re: [PATCH v2] completion: add missing configuration variables
- From
Jeff King <peff@peff.net>
- Date
- Dec 20, 2010, 21:20 UTC
- Message-ID
- <20101220212018.GA18503@sigill.intra.peff.net>
- In-Reply-To
- <1292858305-7679-1-git-send-email-martin.von.zweigbergk@gmail.com>
On Mon, Dec 20, 2010 at 04:18:25PM +0100, Martin von Zweigbergk wrote:
Show 18 quoted lines
> Quite a few configuration variables have been added since 226b343 > (completion: add missing configuration variables to _git_config(), > 2009-05-03). Add these variables to the Bash completion script. > > Also remove the obsolete 'add.ignore-errors' and > 'color.grep.external', as well as 'diff.renameLimit.', which never > existed and rename the misspelled 'sendemail.aliasesfiletype'. > > Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> > --- > Changes since previous version: > > Removed 'add.ignore-errors' and 'color.grep.external'. > > Added 'fetch.recurseSubmodules', which has entered master since last > round. > > (Still based on master.)
Based on our prior discussion, I think this can go in, and all of the other issues can be left for future patches if somebody wants to address them.
Acked-by: Jeff King <peff@peff.net>
-Peff