git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] grep -I: do not bother to read known-binary files

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 15, 2014, 17:42 UTC
Message-ID
<alpine.DEB.1.00.1405151940170.14982@s15462909.onlinehome-server.info>
In-Reply-To
<20140514194128.GC2715@sigill.intra.peff.net>
Hi Peff,
On Wed, 14 May 2014, Jeff King wrote:
Show 11 quoted lines
> On Wed, May 14, 2014 at 05:44:19PM +0200, Stepan Kasal wrote:
> 
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> > Date: Mon, 8 Nov 2010 16:10:43 +0100
> > 
> > Incidentally, this makes grep -I respect the "binary" attribute (actually,
> > the "-text" attribute, but "binary" implies that).
> 
> Hrm. Is this patch still necessary? In the time since this patch was
> written, we did 0826579 (grep: load file data after checking
> binary-ness, 2012-02-02)

I have no time to test this but I trust that you made sure that it works as advertised. In my case, there were about 500 gigabytes of image data intermixed with code, and waiting for 'git grep' was not funny at all (and I did not have time back then to go through a full code submission cycle on the Git mailing list, either).

So I guess we can drop my patch.

Ciao, Johannes

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Junio C HamanoNext: Jeff King
Message 6 of 10 in “grep -I: do not bother to read known-binary files”
  1. grep -I: do not bother to read known-binary filesStepan Kasal, May 14, 2014
  2. Junio C HamanoMay 14, 2014
  3. Jeff KingMay 14, 2014
  4. Jeff KingMay 14, 2014
  5. Junio C HamanoMay 14, 2014
  6. Johannes SchindelinMay 15, 2014
  7. Jeff KingMay 15, 2014
  8. Stepan KasalMay 16, 2014
  9. Jeff KingMay 16, 2014
  10. Stepan KasalMay 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.