Re: [PATCH] grep -I: do not bother to read known-binary files
- From
Jeff King <peff@peff.net>
- Date
- May 14, 2014, 19:44 UTC
- Message-ID
- <20140514194442.GD2715@sigill.intra.peff.net>
- In-Reply-To
- <xmqqbnv0l02r.fsf@gitster.dls.corp.google.com>
On Wed, May 14, 2014 at 10:52:28AM -0700, Junio C Hamano wrote:
Show 15 quoted lines
> I do not think checking 'text' is the right way to do this. The > attribute controls the eof normalization, and people sometimes want > to keep CRLF terminated files in the repository no matter what the > platform is (an example I heard is a sample protocol exchange over > textual network protocol such as HTTP and SMTP), and the way to do > so is to unset it. That would still let them look for patterns in > and compare the changes to these paths. > > Looking for "Marking files as binary" in gitattributes(5) gives us a > more authoritative alternative, I think. In short: > > - If 'diff' is Unset, or > - If 'diff' is Set to X and diff.X.binary is true > > then the contents are not suitable for human consumption.
I responded elsewhere in the thread that I think the patch under discussion is redundant at this point, but just to clarify: grep currently uses the rules you give above, as it builds on the userdiff driver code.
-Peff
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.