Re: [PATCH] grep -I: do not bother to read known-binary files
- From
Jeff King <peff@peff.net>
- Date
- May 16, 2014, 08:29 UTC
- Message-ID
- <20140516082958.GA21956@sigill.intra.peff.net>
- In-Reply-To
- <20140516081957.GA19845@camelia.ucw.cz>
On Fri, May 16, 2014 at 10:19:57AM +0200, Stepan Kasal wrote:
Show 13 quoted lines
> On Thu, May 15, 2014 at 03:22:26PM -0400, Jeff King wrote: > > As the person who is proposing the patch for git.git, I would hope > > Stepan would follow up on such review and confirm whether or not it is > > still needed. > > well, I try to. (I verified that "less -I" works in msysGit before > submitting the fixup back there, fox example.) > > But I think my role is to moderate the reconciliation. > In this case, having read the discussion, I decided to to ask Dscho > to drop the patch. > > (It is always about balancing the risks and the expenses.)
Sure, I think that is reasonable, and I hope I did not sound like "blame Stepan, he was screwed up". After reading Dscho's other message and knowing that he has not much time for git, I was trying to communicate that I did not expect _him_ to be dealing with it.
Git.git has existed for a long time without that patch, so from our perspective, it is a new patch. And as with any new patch, I would expect a submitter who receives review of "eh, don't we already do this" to either look into it, or decide that the review is probably right and not bother with it. And you did the latter, and that is totally fine and reasonable.
>From msysgit's perspective, they may or may not want to revert the patch
that they already have. That is a _separate_ issue, and I think the burden of effort goes the other way. The patch should stay unless somebody goes to the work to confirm that it is not necessary (or unless they want to accept my say-so and indication that I did not do fresh testing, but that is up to them).
Sorry if that is long and/or obvious. There have been enough bad feelings on the list lately that I didn't want there to be a misunderstanding about what I meant.
-Peff
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.