Re: [PATCH] grep -I: do not bother to read known-binary files
- From
Jeff King <peff@peff.net>
- Date
- May 15, 2014, 19:22 UTC
- Message-ID
- <20140515192226.GC29746@sigill.intra.peff.net>
- In-Reply-To
- <alpine.DEB.1.00.1405151940170.14982@s15462909.onlinehome-server.info>
On Thu, May 15, 2014 at 07:42:00PM +0200, Johannes Schindelin wrote:
Show 11 quoted lines
> > Hrm. Is this patch still necessary? In the time since this patch was > > written, we did 0826579 (grep: load file data after checking > > binary-ness, 2012-02-02) > > I have no time to test this but I trust that you made sure that it works > as advertised. In my case, there were about 500 gigabytes of image data > intermixed with code, and waiting for 'git grep' was not funny at all (and > I did not have time back then to go through a full code submission cycle > on the Git mailing list, either). > > So I guess we can drop my patch.
Certainly I tested it at the time (those commits I referenced contain timing information), and it should have improved the workload you describe. I did not test before/after the patch in this thread, but only read it and noticed that it was trying to do the same thing (that is why I said "I suspect...").
As the person who is proposing the patch for git.git, I would hope Stepan would follow up on such review and confirm whether or not it is still needed.
-Peff
-- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.