Re: [PATCH 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>]

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 26, 2010, 16:14 UTC
Message-ID: <alpine.DEB.1.00.1003261712100.7596@pacific.mpi-cbg.de>
In-Reply-To: <20100326124650.GA12215@coredump.intra.peff.net>

Hi,

On Fri, 26 Mar 2010, Jeff King wrote:

Show 16 quoted lines

> On Fri, Mar 26, 2010 at 11:48:41AM +0100, Johannes Schindelin wrote:
> 
> > This supports opening the results of a 'git grep' directly in a pager 
> > (where the pager can be 'vi', too).
> 
> This is not an argument against your patch, but you may be interested in 
> an alternate method:
> 
>   git grep -n $pattern >grep.out vim -q grep.out
> 
> The advantage is that the editor understands the output as a "quickfix" 
> list and lets you cycle through the hits (just like you might with 
> compiler errors). The disadvantage is that quickfix is a vim extension, 
> so "less" and stock "vi" can't do this (I imagine emacs has a similar 
> feature). It's also obviously a little more typing, but you can hide it 
> inside an alias quite easily.

In addition to the disadvantages you are listing, it does not jump directly to the word I am looking for. As you know, I am working with LaTeX files heavily, where convention dictates that a paragraph is represented by a single line in the source code.

So yes, I really need -O, and if a colleague would not have asked me why this useful feature is not in upstream Git, I would not even have submitted the patch pair.

Ciao, Dscho