Re: [PATCH 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>]
- From
Bert Wesarg <bert.wesarg@googlemail.com>
- Date
- Mar 26, 2010, 11:39 UTC
- Message-ID
- <36ca99e91003260439x3d60b851g15b8652d50f61c06@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.1.00.1003261145500.7596@pacific.mpi-cbg.de>
On Fri, Mar 26, 2010 at 11:48, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 28 quoted lines
> > This supports opening the results of a 'git grep' directly in a pager > (where the pager can be 'vi', too). > > This series is purely about convenience, everything the option does can > be done with a regular script or command line. > > But I saw so many people doing their own scripts for that, and in many > cases, they are subtly broken (e.g. > > git grep -z <expr> | xargs -0r vi +/<expr> > > would work as long as you do not have to check the exit status of git > grep from another script) that I finally decided to go for it and send > this patch pair. > > My most common use case for this is to do something like > > git grep -Ovi SomeJustRenamedFile > > to edit all files I might have forgotten to change after a git mv. > > (Actually, to be honest, my use case involves -Pvi, but I will have to > retrain my hands.) > > Johannes Schindelin (2): > grep: Add the option '--open-files-in-pager' > grep -P: allow optional argument specifying the pager (or editor)
Your re-training failed miserable ;-)
I like the idea. But could it make sense to get the line number of the first match to the filename. In the same syntax as on the console (i.e. <file>:<line>:)?
I have also the feeling that -O potion does not like pager with arguments, be it from GIT_PAGER, PAGER, or from the command line.
Regards, Bert