Re: [PATCH 0/2] Teach 'git grep' about --open-files-in-pager=[<pager>]

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: Mar 26, 2010, 20:07 UTC
Message-ID: <36ca99e91003261307m68cb7238u8a5cbbb350c71c97@mail.gmail.com>
In-Reply-To: <alpine.DEB.1.00.1003261714550.7596@pacific.mpi-cbg.de>

Hi,

On Fri, Mar 26, 2010 at 17:18, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 5 quoted lines

>> I have also the feeling that -O potion does not like pager with
>> arguments, be it from GIT_PAGER, PAGER, or from the command line.
>
> You are correct. That's why I said "-O[<pager>]" and not
> "-O[<pager-with-arguments-that-cause-whitespace-problems-especially-with-spaces-in-directory-names-so-you-need-to-make-a-script-wrapper-anyway>]"

I don't know how common it is to have arguments for the pager in GIT_PAGER or PAGER or whether git actually support this, but your first patch definitely does not work with this, regardless of your -O[<pager>] addition of the second patch.

Bert